Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mix-blend-plus-darker utility #12923

Merged

Conversation

clementinelove
Copy link
Contributor

@clementinelove clementinelove commented Feb 11, 2024

This PR adds 'plus-darker' support to mix-blend-mode.

One PR already added 'mix-blend-plus-lighter' (#8288) , but there should also be 'mix-blend-plus-darker' since blend mode also has a 'plus-darker' value that could be added last time.

mix-blend-mode on MDN lists all possible values

From what I know, it seems only Safari supports plus-darker at the moment since this style is used heavily in macOS's vibrant visual style.

@reinink reinink self-assigned this Feb 20, 2024
@reinink reinink changed the title feat: add plus-darker support for mix-blend-mode Add mix-blend-plus-darker utility Feb 20, 2024
@reinink reinink merged commit 86e3890 into tailwindlabs:master Feb 20, 2024
10 checks passed
@reinink
Copy link
Member

reinink commented Feb 20, 2024

Hey thanks! This seems like a reasonable addition given the Safari support 👍

KrisBraun pushed a commit that referenced this pull request Feb 21, 2024
* feat: add plus-darker support for mix-blend-mode

* Fix failing test

* Update changelog

* Formatting

---------

Co-authored-by: Jonathan Reinink <jonathan@reinink.ca>
KrisBraun pushed a commit that referenced this pull request Feb 23, 2024
* feat: add plus-darker support for mix-blend-mode

* Fix failing test

* Update changelog

* Formatting

---------

Co-authored-by: Jonathan Reinink <jonathan@reinink.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants