Fix crash showing completions in Intellisense when using a custom separator #13306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
| @@ -1054,7 +1059,7 @@ function registerPlugins(plugins, context) { | |||
| values: Object.keys(options.values ?? {}), | |||
| hasDash: name !== '@', | |||
| selectors({ modifier, value } = {}) { | |||
| let candidate = '__TAILWIND_PLACEHOLDER__' | |||
| let candidate = `TAILWINDPLACEHOLDER${id}` | |||
There was a problem hiding this comment.
I don't love the placeholder, but I didn't love it before either haha. One potential improvement could be to use a UUID (without the -) but that's almost overkill for this.
crypto.randomUUID().replaceAll('-','')There was a problem hiding this comment.
yeah I really don't like the placeholder either but it's necessary for the current implementation. UUID would definitely be overkill for this.
RobinMalfait
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intellisense uses the internal
getVariantsAPI and its use of__TAILWIND_PLACEHOLDER__crashes inside Tailwind's variant formatting when the separator is_. This crashes the entire completion routine in intellisense and prevents them from appearing.I've changed it to use no "special" characters to prevent the crash. Instead, we use
TAILWINDPLACEHOLDERwith a unique, random ID attached to eliminate potential conflicts with registered utilities.Fixes tailwindlabs/tailwindcss-intellisense#894