Only detect nesting when using @apply
#13325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/issue-13317
branch
from
cfc73de
to
ce0ec5a
Compare
RobinMalfait
commented
Mar 22, 2024
src/lib/expandApplyAtRules.js
Outdated
Comment on lines
445
to
446
| 'Please enable a CSS nesting plugin *before* Tailwind in your configuration.', | ||
| 'See how here: https://tailwindcss.com/docs/using-with-preprocessors#nesting', |
There was a problem hiding this comment.
This part is coming from the original detectNesting code
There was a problem hiding this comment.
Can drop this part with the change above I think.
src/lib/expandApplyAtRules.js
Outdated
| rule.walkRules(() => { | ||
| throw apply.error( | ||
| [ | ||
| `The \`${applyCandidate}\` class cannot be applied because it uses nested CSS.`, |
There was a problem hiding this comment.
This is a new message, so we can definitely change some wording here.
There was a problem hiding this comment.
Maybe something like:
`The \`${applyCandidate}\` class cannot be used with \`@apply\` because \`@apply\` does not currently support nested CSS.`,
'Rewrite the selector without nesting or configure the `tailwindcss/nesting` plugin:',
'https://tailwindcss.com/docs/using-with-preprocessors#nesting',
| } | ||
|
|
||
| rule.walkRules(() => { | ||
| throw apply.error( |
There was a problem hiding this comment.
I used an error instead of a warning like we used to do for 2 reasons:
- All apply issues in this file use
error. - If we just warn, we would still generate incorrect code.
thecrypticace
approved these changes
Mar 23, 2024
This was referenced Mar 24, 2024
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now we've detected nesting and warned our users to ensure that they're using a nesting plugin. All major browsers have proper support for native nesting so there is no need for us to keep warning the user about nested CSS at all.
However, there are still cases where nesting is not allowed and that's when you are using
@apply.If you are using
@apply foowherefoocontains nested CSS, then it will not work as expected, and in this scenario you do need to use a nesting plugin.If you are using
@applyand you are not applying any classes with nesting in them, then you are good to go.Fixes: #13317