Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep underscores in dashed-idents #13538

Open
wants to merge 6 commits into
base: next
Choose a base branch
from
Open

Keep underscores in dashed-idents #13538

wants to merge 6 commits into from
+153 −15

Commits on May 1, 2024

  1. add failing tests to ensure we keep _ in dashed idents

    @RobinMalfait
    RobinMalfait committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bd8f553 View commit details
    Browse the repository at this point in the history

  2. use charCodeAt(…) to be consistent with other parts of the codebase

    @RobinMalfait
    RobinMalfait committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0ce08f8 View commit details
    Browse the repository at this point in the history

  3. use idx, similar to the segment function

    @RobinMalfait
    RobinMalfait committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c4273a4 View commit details
    Browse the repository at this point in the history

  4. improve convertUnderscoresToWhitespace 

    We will now ensure that:

1. Dashed idents are consumed as-is, meaning that underscores (which are
   valid in dashed-idents) are not converted to a space.
2. Strings are handled separately, which means that values that look
   like dashed idents containing underscores are still converted to
   spaces.
    @RobinMalfait
    RobinMalfait committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9071adb View commit details
    Browse the repository at this point in the history

  5. update changelog

    @RobinMalfait
    RobinMalfait committed May 1, 2024
    Configuration menu
    Copy the full SHA
    555a33e View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. convert \_ -> _ 

    But keep any other escaped value as-is (including escape character)
    @RobinMalfait
    RobinMalfait committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f539b2c View commit details
    Browse the repository at this point in the history