Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat the default key as special in createUtilityPlugin(), add mapTheme argument and convertDefaultKey helper function for plugins that need it #1384

Closed
wants to merge 2 commits into from

Conversation

benface
Copy link
Contributor

@benface benface commented Feb 14, 2020

As discussed on Discord. This fixes the "issue" that a default key in the transitionDuration theme object generates a duration class instead of duration-default which makes more sense.

@benface
Copy link
Contributor Author

benface commented May 9, 2020

@adamwathan Do you consider this a breaking change? I'm using a fork of Tailwind in some projects just for this, and wondering if I should just use another key for the default transition duration.

@adamwathan
Copy link
Member

Decided to solve this in a different/simpler way, thanks for this though, always appreciate your input on this stuff.

#2580

@adamwathan adamwathan closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants