Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ring utilities for custom focus styles and rounded outlines #2747

Merged
merged 4 commits into from Nov 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7,374 changes: 6,912 additions & 462 deletions __tests__/fixtures/tailwind-output-flagged.css

Large diffs are not rendered by default.

7,374 changes: 6,912 additions & 462 deletions __tests__/fixtures/tailwind-output-important.css

Large diffs are not rendered by default.

6,510 changes: 6,048 additions & 462 deletions __tests__/fixtures/tailwind-output-no-color-opacity.css

Large diffs are not rendered by default.

7,374 changes: 6,912 additions & 462 deletions __tests__/fixtures/tailwind-output.css

Large diffs are not rendered by default.

12 changes: 8 additions & 4 deletions __tests__/plugins/boxShadow.test.js
Expand Up @@ -45,16 +45,20 @@ test('box shadow can use DEFAULT keyword and negative prefix syntax', () => {
{
utilities: {
'.shadow': {
'box-shadow': '0 1px 3px 0 rgba(0, 0, 0, 0.1), 0 1px 2px 0 rgba(0, 0, 0, 0.06)',
'--box-shadow': '0 1px 3px 0 rgba(0, 0, 0, 0.1), 0 1px 2px 0 rgba(0, 0, 0, 0.06)',
'box-shadow': 'var(--box-shadow)',
},
'.shadow-md': {
'box-shadow': '0 4px 6px -1px rgba(0, 0, 0, 0.1), 0 2px 4px -1px rgba(0, 0, 0, 0.06)',
'--box-shadow': '0 4px 6px -1px rgba(0, 0, 0, 0.1), 0 2px 4px -1px rgba(0, 0, 0, 0.06)',
'box-shadow': 'var(--box-shadow)',
},
'.-shadow': {
'box-shadow': 'inset 0 2px 4px 0 rgba(0, 0, 0, 0.06)',
'--box-shadow': 'inset 0 2px 4px 0 rgba(0, 0, 0, 0.06)',
'box-shadow': 'var(--box-shadow)',
},
'.-shadow-md': {
'box-shadow': '0 4px 6px -1px rgba(0, 0, 0, 0.1), 0 2px 4px -1px rgba(0, 0, 0, 0.06)',
'--box-shadow': '0 4px 6px -1px rgba(0, 0, 0, 0.1), 0 2px 4px -1px rgba(0, 0, 0, 0.06)',
'box-shadow': 'var(--box-shadow)',
},
},
variants: ['responsive'],
Expand Down
5 changes: 5 additions & 0 deletions src/corePluginList.js
Expand Up @@ -69,6 +69,11 @@ export const corePluginList = [
'inset',
'resize',
'boxShadow',
'ringWidth',
'ringOffsetColor',
'ringOffsetWidth',
'ringColor',
'ringOpacity',
'fill',
'stroke',
'strokeWidth',
Expand Down
3 changes: 2 additions & 1 deletion src/plugins/boxShadow.js
Expand Up @@ -8,7 +8,8 @@ export default function () {
return [
nameClass('shadow', modifier),
{
'box-shadow': value,
'--box-shadow': value,
'box-shadow': 'var(--box-shadow)',
},
]
})
Expand Down
5 changes: 5 additions & 0 deletions src/plugins/index.js
Expand Up @@ -85,6 +85,11 @@ export { default as pointerEvents } from './pointerEvents'
export { default as position } from './position'
export { default as preflight } from './preflight'
export { default as resize } from './resize'
export { default as ringColor } from './ringColor'
export { default as ringOffsetColor } from './ringOffsetColor'
export { default as ringOffsetWidth } from './ringOffsetWidth'
export { default as ringOpacity } from './ringOpacity'
export { default as ringWidth } from './ringWidth'
export { default as rotate } from './rotate'
export { default as scale } from './scale'
export { default as skew } from './skew'
Expand Down
32 changes: 32 additions & 0 deletions src/plugins/ringColor.js
@@ -0,0 +1,32 @@
import _ from 'lodash'
import flattenColorPalette from '../util/flattenColorPalette'
import nameClass from '../util/nameClass'
import { toRgba } from '../util/withAlphaVariable'

export default function () {
return function ({ addUtilities, theme, variants }) {
const colors = flattenColorPalette(theme('ringColor'))
const utilities = _.fromPairs(
_.map(_.omit(colors, 'DEFAULT'), (value, modifier) => {
try {
const [r, g, b, a] = toRgba(value)
return [
nameClass('ring', modifier),
{
'--ring-opacity': a === undefined ? '1' : a,
'--ring-color': `rgba(${r}, ${g}, ${b}, var(--ring-opacity))`,
},
]
} catch (_error) {
return [
nameClass('ring', modifier),
{
'--ring-color': value,
},
]
}
})
)
addUtilities(utilities, variants('ringColor'))
}
}
20 changes: 20 additions & 0 deletions src/plugins/ringOffsetColor.js
@@ -0,0 +1,20 @@
import _ from 'lodash'
import flattenColorPalette from '../util/flattenColorPalette'
import nameClass from '../util/nameClass'

export default function () {
return function ({ addUtilities, theme, variants }) {
const colors = flattenColorPalette(theme('ringOffsetColor'))
const utilities = _.fromPairs(
_.map(colors, (value, modifier) => {
return [
nameClass('ring-offset', modifier),
{
'--ring-offset-color': value,
},
]
})
)
addUtilities(utilities, variants('ringOffsetColor'))
}
}
18 changes: 18 additions & 0 deletions src/plugins/ringOffsetWidth.js
@@ -0,0 +1,18 @@
import _ from 'lodash'
import nameClass from '../util/nameClass'

export default function () {
return function ({ addUtilities, theme, variants }) {
const utilities = _.fromPairs(
_.map(theme('ringOffsetWidth'), (value, modifier) => {
return [
nameClass('ring-offset', modifier),
{
'--ring-offset-width': value,
},
]
})
)
addUtilities(utilities, variants('ringOffsetWidth'))
}
}
18 changes: 18 additions & 0 deletions src/plugins/ringOpacity.js
@@ -0,0 +1,18 @@
import _ from 'lodash'
import nameClass from '../util/nameClass'

export default function () {
return function ({ addUtilities, theme, variants }) {
const utilities = _.fromPairs(
_.map(_.omit(theme('ringOpacity'), 'DEFAULT'), (value, modifier) => {
return [
nameClass('ring-opacity', modifier),
{
'--ring-opacity': value,
},
]
})
)
addUtilities(utilities, variants('ringOpacity'))
}
}
37 changes: 37 additions & 0 deletions src/plugins/ringWidth.js
@@ -0,0 +1,37 @@
import _ from 'lodash'
import nameClass from '../util/nameClass'
import { toRgba } from '../util/withAlphaVariable'

export default function () {
return function ({ addUtilities, theme, variants }) {
function safeCall(callback, defaultValue) {
try {
return callback()
} catch (_error) {
return defaultValue
}
}

const ringColorDefault = (([r, g, b]) => {
return `rgba(${r}, ${g}, ${b}, ${theme('ringOpacity.DEFAULT', '0.5')})`
})(safeCall(() => toRgba(theme('ringColor.DEFAULT')), ['147', '197', '253']))

const utilities = _.fromPairs(
_.map(theme('ringWidth'), (value, modifier) => {
return [
nameClass('ring', modifier),
{
'--ring-width': value,
'--ring-color-default': ringColorDefault,
'box-shadow': [
`0 0 0 var(--ring-offset-width, 0) var(--ring-offset-color, #fff)`,
`0 0 0 calc(var(--ring-width) + var(--ring-offset-width, 0px)) var(--ring-color, var(--ring-color-default))`,
`var(--box-shadow, 0 0 #0000)`,
].join(', '),
},
]
})
)
addUtilities(utilities, variants('ringWidth'))
}
}
34 changes: 31 additions & 3 deletions stubs/defaultConfig.stub.js
Expand Up @@ -125,16 +125,13 @@ module.exports = {
8: '8px',
},
boxShadow: {
xs: '0 0 0 1px rgba(0, 0, 0, 0.05)',
sm: '0 1px 2px 0 rgba(0, 0, 0, 0.05)',
DEFAULT: '0 1px 3px 0 rgba(0, 0, 0, 0.1), 0 1px 2px 0 rgba(0, 0, 0, 0.06)',
md: '0 4px 6px -1px rgba(0, 0, 0, 0.1), 0 2px 4px -1px rgba(0, 0, 0, 0.06)',
lg: '0 10px 15px -3px rgba(0, 0, 0, 0.1), 0 4px 6px -2px rgba(0, 0, 0, 0.05)',
xl: '0 20px 25px -5px rgba(0, 0, 0, 0.1), 0 10px 10px -5px rgba(0, 0, 0, 0.04)',
'2xl': '0 25px 50px -12px rgba(0, 0, 0, 0.25)',
inner: 'inset 0 2px 4px 0 rgba(0, 0, 0, 0.06)',
outline: '0 0 0 3px rgba(147, 197, 253, 0.5)',
solid: '0 0 0 2px currentColor',
none: 'none',
},
container: {},
Expand Down Expand Up @@ -498,6 +495,7 @@ module.exports = {
},
opacity: {
0: '0',
5: '0.05',
10: '0.1',
20: '0.2',
25: '0.25',
Expand All @@ -509,6 +507,7 @@ module.exports = {
75: '0.75',
80: '0.8',
90: '0.9',
95: '0.95',
100: '1',
},
order: {
Expand Down Expand Up @@ -536,6 +535,30 @@ module.exports = {
padding: (theme) => theme('spacing'),
placeholderColor: (theme) => theme('colors'),
placeholderOpacity: (theme) => theme('opacity'),
ringColor: (theme) => ({
DEFAULT: theme('colors.blue.500'),
...theme('colors'),
}),
ringOffsetColor: (theme) => theme('colors'),
ringOffsetWidth: {
0: '0',
1: '1px',
2: '2px',
4: '4px',
8: '8px',
},
ringOpacity: (theme) => ({
DEFAULT: '0.5',
...theme('opacity'),
}),
ringWidth: {
DEFAULT: '3px',
0: '0',
1: '1px',
2: '2px',
4: '4px',
8: '8px',
},
rotate: {
'-180': '-180deg',
'-90': '-90deg',
Expand Down Expand Up @@ -794,6 +817,11 @@ module.exports = {
pointerEvents: ['responsive'],
position: ['responsive'],
resize: ['responsive'],
ringColor: ['responsive'],
ringOffsetColor: ['responsive'],
ringOffsetWidth: ['responsive'],
ringOpacity: ['responsive'],
ringWidth: ['responsive', 'focus'],
rotate: ['responsive', 'hover', 'focus'],
scale: ['responsive', 'hover', 'focus'],
skew: ['responsive', 'hover', 'focus'],
Expand Down