Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-decoration-style utilities #5970

Closed
wants to merge 1 commit into from
Closed

Add text-decoration-style utilities #5970

wants to merge 1 commit into from

Conversation

xiBread
Copy link
Contributor

@xiBread xiBread commented Nov 3, 2021

Adds text-decoration-style utilities.

I've left the name as decoration-* but I'm thinking it should be changed to disambiguate from the existing box decoration break utilities. I had decoration-style-* in mind but I'm open to suggestions.

@neupauer
Copy link
Contributor

neupauer commented Nov 3, 2021

Hey, I like that one.

How about adding the whole text-decoration module?

CSS Property Example Notes
text-decoration-line .decoration-underline, .decoration-overline can be chained
text-decoration-color .decoration-red-500
text-decoration-style .decoration-dashed
text-decoration-thickness .decoration-2
text-underline-offset .decoration-offset-2

I like the decoration prefix, so maybe in v 3.0 the box-decoration-break could be renamed to box-decoration? It doesn't have to be breaking-change because .decoration-slice and .decoration-clone doesn't collide with anything (can be marked as an deprecated alias).

I don't have time to prepare a PR right now, so I'm just giving my opinion and maybe inspiration here.

@xiBread
Copy link
Contributor Author

xiBread commented Nov 7, 2021

Continued in #6004.

@xiBread xiBread closed this Nov 7, 2021
@xiBread xiBread deleted the feat/text-decoration-style branch November 7, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants