Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-emphasis-* utilities #6003

Closed
wants to merge 1 commit into from
Closed

Add text-emphasis-* utilities #6003

wants to merge 1 commit into from

Conversation

xiBread
Copy link
Contributor

@xiBread xiBread commented Nov 7, 2021

Adds utilities for:

The property for text-emphasis-style is text-emphasis to be consistent with text-decoration.

@lukewarlow
Copy link
Contributor

I personally think it should use the long hand properties for all of them. Otherwise there's unintuitive override behaviour when using multiple properties together. Which someone's trying to fix for text-decoration here #6378

@adamwathan
Copy link
Member

Hey thanks for the PR! This is quite a lot of API (and selfishly new documentation to write and maintain) for something that I think isn't very commonly used so I think for now I want to say no to this and recommend throwing it into a plugin if you want to reuse it across your projects.

Not opposed to adding it one day in the future but since this has been sitting open forever I feel like it's best to make a decision on it for now. Thanks either way I do appreciate it! ❤️

If I'm missing a really obvious and popular use case for this please create either a discussion or a new PR with some more details and can definitely revisit.

@adamwathan adamwathan closed this May 23, 2022
@xiBread xiBread deleted the feat/text-emphasis branch June 6, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants