Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all plugins are executed for a given candidate #6540

Merged
merged 2 commits into from Dec 15, 2021
Merged

Ensure all plugins are executed for a given candidate #6540

merged 2 commits into from Dec 15, 2021

Commits on Dec 15, 2021

  1. remove early return so that all plugins are handled 

    We had an early return so that once a plugin was matched, that we could
stop running the code through the other plugins. However, in this case
we have an issue that user defined css is technically also a plugin.

This means that:
  - `bg-green-light`
Would check for:
  - `bg-green-light` (no hit, continue)
  - `bg-green` (Hit! Don't execute next plugins)
  - `bg` (This is the one that would have generated `bg-green-light`)

We tested this change and it doesn't seem to have an impact functionally
and also not really performance wise.
    @RobinMalfait
    RobinMalfait committed Dec 15, 2021
    Copy the full SHA
    658f528 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Dec 15, 2021
    Copy the full SHA
    764c5c0 View commit details
    Browse the repository at this point in the history