Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid writing to output files when no changes #6550

Merged
merged 3 commits into from Jan 4, 2022
Merged

Avoid writing to output files when no changes #6550

merged 3 commits into from Jan 4, 2022

Commits on Dec 15, 2021

  1. fix(cli): avoid write same output when no changes

    @g3offrey
    g3offrey committed Dec 15, 2021
    Copy the full SHA
    d360b10 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. generalize outputFile 

    This function will check a cache, it will only write the file if:
- The modified timestamps changed since last time we wrote something.
  This is useful to know if something changed by another tool or
  manually without diffing the full file.
- The contents changed.
    @RobinMalfait
    RobinMalfait committed Jan 4, 2022
    Copy the full SHA
    a954031 View commit details
    Browse the repository at this point in the history

  2. further simplify checks 

    Turns out that reading files and comparing them is fairly fast and there
is no huge benefit over only using the Stats of the file and keeping
track of that information.

Thanks @kentcdodds!
    @RobinMalfait
    RobinMalfait committed Jan 4, 2022
    Copy the full SHA
    df0c314 View commit details
    Browse the repository at this point in the history