Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional chaining usage #7076

Closed
wants to merge 1 commit into from
Closed

Remove optional chaining usage #7076

wants to merge 1 commit into from

Conversation

chuntington
Copy link
Contributor

This PR removes the use of optional chaining syntax to ensure compatibility with Node.js versions 13 and below.

For reference: 8293c2d#r63911585

@chuntington chuntington changed the title remove optional chaining Remove optional chaining usage Jan 14, 2022
@adamwathan
Copy link
Member

Hey! This isn't necessary, we transpile all of our code to work for node 12 before publishing:

https://github.com/tailwindlabs/tailwindcss/blob/master/.swcrc

If you are hitting this when running locally or something you should make sure you are running the transpiled code:

https://github.com/tailwindlabs/tailwindcss/blob/master/package.json#L22

@adamwathan adamwathan closed this Jan 14, 2022
@chuntington
Copy link
Contributor Author

Thanks for reaching out @adamwathan!

I'm running into issues using Node.js v12 and this configuration: https://github.com/chuntington/webpack-boilerplate/blob/master/postcss.config.js

In that project, do you know what should I do/change to run the transpiled code?

@RobinMalfait
Copy link
Contributor

Hey!

Sorry this is my fault, I have a quick fix here and will do a proper fix tomorrow. In the meantime I'll get this merged and will release a new version so that it works again: #7077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants