Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) #7080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to be 100% sure that we can safely call hasOwnProperty in case we get some very strange objects. This will now also be compiled/transpiled by esbuild.
This allows us to work on it without re-compiling while running tests. Just like we do with all other code.
RobinMalfait
force-pushed
the
compile-nesting-plugin
branch
from
b217f91
to
73193e8
Compare
dukex
added a commit
to dukex/tailwindcss-rails
that referenced
this pull request
Feb 15, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
dhh
pushed a commit
to rails/tailwindcss-rails
that referenced
this pull request
Feb 19, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
aisen-lopez
pushed a commit
to aisen-lopez/rails-tailwindcss-template
that referenced
this pull request
Apr 1, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
anderscain63
added a commit
to anderscain63/tailwindcss-rails
that referenced
this pull request
Dec 20, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
titan2gman
added a commit
to titan2gman/tailwindcss-rails
that referenced
this pull request
Dec 27, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
smartech7
pushed a commit
to smartech7/rails-tailwind-css
that referenced
this pull request
Aug 4, 2023
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
RabbitDev810
pushed a commit
to RabbitDev810/tailwind-rails
that referenced
this pull request
Jan 22, 2024
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make sure that we are transpiling the nesting plugin that we expose. We didn't do that before and it was totally fine. But we also added an additional check recently that used optional chaining and this broke when people used Node versions lower than 13 (even though we require Node 12).
This PR fixes that by making sure that we transpile this code just like we do with all other code.
We also re-added the optional chaining that broke things to be sure that we don't crash when we retrieve "broken" objects somehow.
This also undoes the temporary change I introduced in #7077 last night. (Who says temporary changes are permanent 馃槄)