Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove false positive warning in CLI when using the --content option #7220

Merged
merged 2 commits into from Jan 26, 2022
Merged

Remove false positive warning in CLI when using the --content option #7220

merged 2 commits into from Jan 26, 2022

Commits on Jan 26, 2022

  1. ensure content files are available in config 

    If you use the cli with the `--content` option, then we first resolve
the config (empty), then add the `content` to the config. The issue is
that this means that the content will be empty when you resolve it
initially. This results in a warning in your terminal.

Now, we will make sure to merge 2 configs if you have the `--content`
data passed. We will also make sure to override the final
`config.content.files` to whatever you passed in to make sure that this
is the same behaviour as before.
    @RobinMalfait
    RobinMalfait committed Jan 26, 2022
    Copy the full SHA
    103062f View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Jan 26, 2022
    Copy the full SHA
    bebebdc View commit details
    Browse the repository at this point in the history