Add an explicit --poll option to the CLI
#7725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
feature/cli-polling
branch
from
fe2dd67
to
bb69168
Compare
thecrypticace
force-pushed
the
feature/cli-polling
branch
2 times, most recently
from
809cd3b
to
0a6f145
Compare
adamwathan
reviewed
Mar 2, 2022
thecrypticace
force-pushed
the
feature/cli-polling
branch
from
ece31cb
to
d58fe64
Compare
|
wat the vite integration test failed. Seems like a spurious failure. 👀 |
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently enable
awaitWriteFinishon Windows because a file may be created, an event delivered for that, and then written to and these events are not necessarily coalesced. This may also be necessary to do over network connections — for example when using SSH. Additionally,watchFile-based polling in chokidar is recommended when watching files over a network connection. If polling is not used rebuilds may happen too early or even not at all when working over a network.I've added an explicit flag (
--poll) that lets user's enable polling behavior in case they're operating over a network or otherwise have latency issues on when a file is created / written to / done writing.Fixes #7467