Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check selectors containing apply candidates for circular dependencies #8222

Merged
merged 2 commits into from May 2, 2022
Merged

Only check selectors containing apply candidates for circular dependencies #8222

merged 2 commits into from May 2, 2022

Commits on May 2, 2022

  1. Only check selectors containing base apply candidates for circular de… 

    …pendencies

When given a two rule like `html.dark .a, .b { … }` and `html.dark .c { @apply b }` we would see `.dark` in both the base rule and the rule being applied and consider it a circular dependency. However, the selectors `html.dark .a` and `.b` are considered on their own and is therefore do not introduce a circular dependency.

This better matches the user’s mental model that the selectors are just two definitions sharing the same properties.
    @thecrypticace
    thecrypticace committed May 2, 2022
    Copy the full SHA
    fa27c46 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @thecrypticace
    thecrypticace committed May 2, 2022
    Copy the full SHA
    3f38cab View commit details
    Browse the repository at this point in the history