Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow returning parallel variants from addVariant or matchVariant callback functions #8455

Merged
merged 9 commits into from May 31, 2022

Commits on May 27, 2022

  1. Copy the full SHA
    9824a79 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    6b15caa View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    f5369ca View commit details
    Browse the repository at this point in the history
  4. allow to return parallel variants from variant function

    Caveat: this now belongs to the same plugin and is not registered as
    separate variants which means that sort order can differ.
    RobinMalfait committed May 27, 2022
    Copy the full SHA
    e1006f8 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    f94311b View commit details
    Browse the repository at this point in the history
  6. update changelog

    RobinMalfait committed May 27, 2022
    Copy the full SHA
    be09acc View commit details
    Browse the repository at this point in the history
  7. ensure that we use a local list of variant functions

    Now that a variant function can return a list of variant functions from
    within the plugin, we have to make sure to executed and register those
    functions as well.
    
    However, we need to make sure that this list is local for the variant
    and not "globally" registered otherwise we keep add a dynamic function
    to the global list which results in duplicate output becaus multiple
    duplicate variants will be registered.
    RobinMalfait committed May 27, 2022
    Copy the full SHA
    fbeaca8 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    dae24b7 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Update CHANGELOG.md

    RobinMalfait committed May 31, 2022
    Copy the full SHA
    641400a View commit details
    Browse the repository at this point in the history