Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect arbitrary variants with quotes #8687

Merged
merged 3 commits into from Jun 20, 2022
Merged

Detect arbitrary variants with quotes #8687

merged 3 commits into from Jun 20, 2022

Commits on Jun 20, 2022

  1. Refactor

    @thecrypticace
    thecrypticace committed Jun 20, 2022
    Copy the full SHA
    9fe4797 View commit details
    Browse the repository at this point in the history

  2. Support variants with quotes in them 

    We have to have two regexes here because this is actually ambiguous in the general case. The regex that generally handles `[&[foo='bar']]` would incorrectly match `['bar':'baz']` for instance. So, instead we’ll use multiple regexes and match both!
    @thecrypticace
    thecrypticace committed Jun 20, 2022
    Copy the full SHA
    80c7bbe View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @thecrypticace
    thecrypticace committed Jun 20, 2022
    Copy the full SHA
    dc4b13b View commit details
    Browse the repository at this point in the history