Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add word-break: keep-all with break-keep #9393

Merged
merged 2 commits into from Sep 22, 2022
Merged

✨ Add word-break: keep-all with break-keep #9393

merged 2 commits into from Sep 22, 2022

Conversation

k-utsumi
Copy link
Contributor

ref. https://developer.mozilla.org/en-US/docs/Web/CSS/word-break

whitespace-nowrap and word-break: keep-all behave differently in different browsers.

Demo: https://jsfiddle.net/h1aj6nvy/

There is a difference between Firefox and Google chrome.

k-utsumi and others added 2 commits September 22, 2022 19:59
ref. https://developer.mozilla.org/en-US/docs/Web/CSS/word-break

`whitespace-nowrap` and `word-break: keep-all` behave differently in different browsers.

Demo: https://jsfiddle.net/h1aj6nvy/

There is a difference between Firefox and Google chrome.
@reinink
Copy link
Member

reinink commented Sep 22, 2022

@k-utsumi Hey thanks for this contribution! Just chatted with the team about this, and while we like the addition, we are going to call this utility .break-keep instead of .keep-all to keep all the word-break utilities consistent 👍

@reinink reinink merged commit 2574a88 into tailwindlabs:master Sep 22, 2022
@reinink reinink changed the title ✨ Add word-break: keep-all with keep-all ✨ Add word-break: keep-all with break-keep Sep 22, 2022
@k-utsumi k-utsumi deleted the patch-1 branch September 22, 2022 22:03
@k-utsumi
Copy link
Contributor Author

Thanks 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants