Exclude non-relevant selectors when generating rules with the important modifier. Fixes #9677. #9704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just want to say this is one of the most well-executed PRs we've ever received — thanks for taking the time to figure out the best/simplest way to solve this issue, for including tests, and for updating the changelog, all looks great! 🙌 |
|
Thanks Adam! Glad I could help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue described in #9677.
With this change, when an important modifier is applicable to a rule with multiple selectors, the generated rule with important declarations will only include selectors that include the modified class.