Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix !important selectors not being classified as valid class inside safelist config #9791

Merged
merged 6 commits into from Nov 9, 2022

Conversation

akbng
Copy link
Contributor

@akbng akbng commented Nov 9, 2022

This PR resolves issue #9759

PR includes

  • add the '!' prefix as a valid class inside safelisting options
  • include tests for the same

@thecrypticace thecrypticace self-assigned this Nov 9, 2022
@thecrypticace
Copy link
Contributor

Hey, thanks for the PR! Could you add an additional check that the regex pattern contains the ! character anywhere? We're good with adding this but don't want people to pay for the perf penalty of checking basically doubling the generated classes if they don't need them.

@akbng
Copy link
Contributor Author

akbng commented Nov 9, 2022

Hey, thanks for the PR! Could you add an additional check that the regex pattern contains the ! character anywhere? We're good with adding this but don't want people to pay for the perf penalty of checking basically doubling the generated classes if they don't need them.

sure I can try that and also saw some failing tests as well - will try to fix them 👍

EDIT: Looks like I need a different strategy like you suggested without conflicting with other checks

@thecrypticace
Copy link
Contributor

If you do that you won't need to fix the failing tests :)

@thecrypticace
Copy link
Contributor

Actually, I've already got an implementation. Lemme push it

@akbng
Copy link
Contributor Author

akbng commented Nov 9, 2022

Thanks for the help

@thecrypticace thecrypticace merged commit 8a2f9ed into tailwindlabs:master Nov 9, 2022
@thecrypticace
Copy link
Contributor

Thank you! 🎉

@akbng
Copy link
Contributor Author

akbng commented Nov 9, 2022

WOW! I didn't expected such fast action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants