Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render external resource OG #23

Merged
merged 18 commits into from Nov 18, 2022
Merged

render external resource OG #23

merged 18 commits into from Nov 18, 2022

Conversation

takurinton
Copy link
Owner

@takurinton takurinton commented Oct 11, 2022

define custom syntax with marked

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ssg-blog ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 10:46PM (UTC)

@takurinton
Copy link
Owner Author

ここから下くらいを読みながら
https://marked.js.org/using_pro#extensions

@takurinton
Copy link
Owner Author

takurinton commented Oct 11, 2022

local

hogehoge

@og[https://blog.takurinton.dev/post/111]

@twitter[https://twitter.com/takurinton/status/1579390918603706368]

image

@takurinton
Copy link
Owner Author

Node.js のバージョンの問題、ここの話だ。
preactjs/wmr#935 (comment)

@takurinton
Copy link
Owner Author

動作はいいけど Node.js v17 以前で wmr は fetch の上書きができないのと、node-fetch を使うと何故か crash するので一旦保留。

作戦としては

  • vercel が Node.js v18 対応するのを待つ(これは少しばかり時間がかかりそう)
  • GitHub Actions には Node.js v18 のイメージがあるのでビルドはそれを使って行い、upload を verce API で行う

あたりが考えられる、後者かな。

@takurinton
Copy link
Owner Author

思ったよりも早く対応されていた
https://vercel.com/changelog/node-js-18-lts-is-now-available

"preact-iso": "2.3.0"
"jsdom": "^20.0.1",
"marked": "4.1.0",
"preact": "10.11.0",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preact is broken since 10.11.1 due to SignalLike changes...
I can't think of a good way to do it, so downgrade once and use it
image

preactjs/preact#3747

@takurinton takurinton marked this pull request as ready for review November 18, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant