New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packaging and documentation #97
Conversation
Also, you can enable the PR builder on Read the Docs to see how this would look like: https://blog.readthedocs.com/pull-request-builder-general-availability/ |
@astrojuanlu Thanks! It's enabled now! |
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 99 99
Lines 7383 7383
=======================================
Hits 6864 6864
Misses 519 519 Continue to review full report at Codecov.
|
The Read the Docs build is done now! Still fails importing, but as I said it looks like a problem with the aurosummary templates |
As I explained in sphinx-doc/sphinx#7989, the
However, launching a Python interpreter doesn't have this problem. I think I got how to fix it, will push one more commit. |
This requires installing the code to build the docs.
@takuseno problem fixed, have a look at the build logs 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! You save my days!!! I've left one minor comment. I'd like you to take a look at it. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change! I'll merge this when the test has passed.
Fix #96