Skip to content

Commit

Permalink
chore(pubsub): additional buckets to consume_latency prom metrics (#697)
Browse files Browse the repository at this point in the history
We're increasing the amount of buckets in
`gcloud_aio_pubsub_subscriber_consume_latency_seconds_bucket` to enable
better tracking of tail end latencies.
  • Loading branch information
juanamari94 committed Mar 14, 2024
1 parent c011a7c commit 9263a38
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ may need to keep this in mind while developing; all code will need to be
generateable into both module trees and runnable without asyncio (though there
are some conversion scripts we run to make things a bit more ergonomic --
you're generally safe to write standard asyncio code and rely on the
conversation script). Feel free to ping a maintainer if you're having issues
conversion script). Feel free to ping a maintainer if you're having issues
with this!

To build and test against the ``gcloud-rest`` projects, you can run:
Expand Down
2 changes: 2 additions & 0 deletions pubsub/gcloud/aio/pubsub/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
namespace=_NAMESPACE,
subsystem=_SUBSYSTEM,
unit='seconds',
buckets=(.01, .1, .25, .5, 1.0, 2.5, 5.0, 7.5, 10.0, 20.0,
30.0, 60.0, 120.0, float('inf')),
)

BATCH_STATUS = prometheus_client.Counter(
Expand Down
2 changes: 1 addition & 1 deletion pubsub/poetry.rest.lock
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This file is automatically @generated by Poetry 1.8.2 and should not be changed by hand.
# This file is automatically @generated by Poetry 1.8.1 and should not be changed by hand.

[[package]]
name = "backoff"
Expand Down
2 changes: 1 addition & 1 deletion pubsub/pyproject.rest.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "gcloud-rest-pubsub"
version = "6.0.0"
version = "6.0.1"
description = "Python Client for Google Cloud Pub/Sub"
readme = "README.rst"

Expand Down
2 changes: 1 addition & 1 deletion pubsub/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "gcloud-aio-pubsub"
version = "6.0.0"
version = "6.0.1"
description = "Python Client for Google Cloud Pub/Sub"
readme = "README.rst"

Expand Down

0 comments on commit 9263a38

Please sign in to comment.