feat(theme names): short css theme names initial changes #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ehxxn
changed the title
ehxxn
changed the title
natew
reviewed
Jan 21, 2024
| @@ -211,11 +211,18 @@ const monoFont = createGenericFont( | |||
| } | |||
| ) | |||
|
|
|||
| let themeKeysOnly = Object.fromEntries( | |||
| Object.entries(themesIn).map(([key], index) => [key, index]) | |||
There was a problem hiding this comment.
Can't we just use the index of the array and just use Object.keys()?
natew
reviewed
Jan 25, 2024
| const noThemes = areThemesJustNames | ||
| ? false | ||
| : Object.keys(configIn.themes).length === 0 | ||
| const noThemes = areThemesJustNames ? true : Object.keys(configIn.themes).length === 0 |
There was a problem hiding this comment.
it should be backward compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.