Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add web only filter, backdrop, mix-blend-mode #2265

Merged
merged 34 commits into from
May 12, 2024

Conversation

ehxxn
Copy link
Member

@ehxxn ehxxn commented Feb 13, 2024

add the following props support ( web only )
filter
backdropFilter
mixMlendMode

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 10:59am
studio 🔄 Building (Inspect) Visit Preview May 12, 2024 10:59am

@natew
Copy link
Member

natew commented Feb 15, 2024

we need to update the docs for these too in styles.mdx. if we're updating these, we should be more thorough and catalog which are important and at least plausibly likely to be implemented by react native add a few more.

@ehxxn
Copy link
Member Author

ehxxn commented Feb 15, 2024

we need to update the docs for these too in styles.mdx. if we're updating these, we should be more thorough and catalog which are important and at least plausibly likely to be implemented by react native add a few more.

we can also have these in react-native, there is a library for that. but for now we can skip it

@natew
Copy link
Member

natew commented Mar 3, 2024

We should make this pr comprehensive and add all the style props we think we want for v2 basically.

Some candidates:

  • mask
  • maskImage
  • textEmphasis
  • borderImage
  • aspectRatio

Etc, probably at least 20 more are desirably at least.

We should reference here: react-native-community/discussions-and-proposals#496

See "CSS Compatibility" (objectFit, verticalAlign).

I want to have one release where we deprecate all the old stuff from here and add the new stuff react-native-community/discussions-and-proposals#496

Some deprecations (jsdoc can tell people what the new value is):

  • selectable => userSelect
  • focusable => tabIndex

@ehxxn
Copy link
Member Author

ehxxn commented Mar 5, 2024

@natew Added 38 more style props
I think it's better to have a separate PR to make current Apis compatible with web and deprecate old ones.
and keep this PR just adding new web styles

@ehxxn ehxxn marked this pull request as ready for review March 5, 2024 15:19
apps/site/components/HeaderMenu.tsx Show resolved Hide resolved
inset?: SpaceTokens | number;
insetBlock?: SpaceTokens | number;
insetBlockStart?: SpaceTokens | number;
insetBlockEnd?: SpaceTokens | number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these supported on native?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, they are mapped to native alternatives.
like paddingInline to paddingHorizontal

@natew natew merged commit f944eb1 into master May 12, 2024
6 of 8 checks passed
@natew natew deleted the feat/core-add-web-only-props branch May 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants