Set up linting #29
Merged
Set up linting #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Prettier plugin/config to ESLint * Set lint-staged to run both ESLint and Prettier as appropriate * Broaden lint-staged globs, because gitignored files won't be staged anyway * Lint `./tests` * Sort `package.json` canonically * Fix project name in `package.json`
Manually alphabetize import groups and lines pending the merging of import-js/eslint-plugin-import#1360, using WebStorm's Optimize imports
|
Added import linting, per discussion on #30. Revisit that once import-js/eslint-plugin-import#1360 is merged. In the meantime, perhaps make some nominal effort to keep imports alphabetized manually. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't lint imports. Still looking into how do to that well. Each rule/preset/plugin does some of the work, and they all conflict with each other.