Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --no-stack option to command line #28

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add --no-stack option to command line #28

wants to merge 1 commit into from

Conversation

numical
Copy link

@numical numical commented May 18, 2019

Command line option to enable even more concise output by not including stack traces in output.
e.g.:

faucet *.test --no-stack
X example
  not ok 3 fail test 1
  not ok 4 fail test 2
# tests 4
# pass  2
# fail  2

@numical @ljharb
[New] add --no-stack option to command line
8803e20 
will also look for SHOW_STACK environmental variable
@ljharb ljharb changed the title add --no-stack opion to command line add --no-stack option to command line Sep 22, 2022
ljharb
ljharb reviewed Sep 22, 2022
View reviewed changes
bin/cmd.js
});
var opts = {
width: defined(argv.w, argv.width, process.stdout.isTTY ? process.stdout.columns - 5 : 0),
stack: defined(argv.stack, process.env.SHOW_STACK ? process.env.SHOW_STACK === 'true' : true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally it's best to have absence and false be the same - can we invert this to "hideStack" instead?

(altho i do like --no-stack as the CLI arg name)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ljharb ljharb marked this pull request as draft March 19, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@dimitrov897 dimitrov897 dimitrov897 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@numical @ljharb @dimitrov897