Skip to content

Commit

Permalink
[Refactor] avoid reassigning arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
ljharb committed Jul 24, 2021
1 parent da45ae6 commit 8a0ab53
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions index.js
Expand Up @@ -35,13 +35,13 @@ module.exports = (function () {
};

lazyLoad.createStream = function (opts) {
if (!opts) opts = {};
var options = opts || {};
if (!harness) {
var output = through();
getHarness({ stream: output, objectMode: opts.objectMode });
getHarness({ stream: output, objectMode: options.objectMode });
return output;
}
return harness.createStream(opts);
return harness.createStream(options);
};

lazyLoad.onFinish = function () {
Expand All @@ -65,9 +65,9 @@ module.exports = (function () {
})();

function createExitHarness(conf, wait) {
if (!conf) conf = {};
var config = conf || {};
var harness = createHarness({
autoclose: defined(conf.autoclose, false)
autoclose: defined(config.autoclose, false)
});
var running = false;
var ended = false;
Expand All @@ -78,7 +78,7 @@ function createExitHarness(conf, wait) {
run();
}

if (conf.exit === false) return harness;
if (config.exit === false) return harness;
if (!canEmitExit || !canExit) return harness;

process.on('exit', function (code) {
Expand Down Expand Up @@ -106,8 +106,8 @@ function createExitHarness(conf, wait) {
function run() {
if (running) return;
running = true;
var stream = harness.createStream({ objectMode: conf.objectMode });
var es = stream.pipe(conf.stream || createDefaultStream());
var stream = harness.createStream({ objectMode: config.objectMode });
var es = stream.pipe(config.stream || createDefaultStream());
if (canEmitExit) {
es.on('error', function (err) { harness._exitCode = 1; });
}
Expand All @@ -121,9 +121,8 @@ module.exports.test = module.exports; // tap compat
module.exports.test.skip = Test.skip;

function createHarness(conf_) {
if (!conf_) conf_ = {};
var results = createResult();
if (conf_.autoclose !== false) {
if (!conf_ || conf_.autoclose !== false) {
results.once('done', function () { results.close(); });
}

Expand Down

0 comments on commit 8a0ab53

Please sign in to comment.