Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] improve t.throws documentation #542

Merged
merged 1 commit into from Jan 26, 2021
Merged

[readme] improve t.throws documentation #542

merged 1 commit into from Jan 26, 2021

Conversation

cagross
Copy link
Contributor

@cagross cagross commented Jan 26, 2021

  • Added usage example for when expected parameter is a validation object.

Addresses #540.

* Added usage example for when expected parameter is a validation object.

See #540.
@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #542 (94220ba) into master (ce0b1ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   74.15%   74.15%           
=======================================
  Files          19       19           
  Lines         766      766           
  Branches      146      146           
=======================================
  Hits          568      568           
  Misses        198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0b1ad...94220ba. Read the comment docs.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@ljharb ljharb merged commit 94220ba into tape-testing:master Jan 26, 2021
@cagross
Copy link
Contributor Author

cagross commented Jan 27, 2021

Great, thanks for allowing me to help :-) Again, if there are issues with that documentation, or it needs modification/augmentation, feel free to ping me and I'll be happy to take a look.

ljharb added a commit that referenced this pull request Feb 20, 2021
 - [New] add `.teardown()` on `t` instances (#546)
 - [readme] improve `t.throws` documentation (#542)
 - [readme] improve `t.throws`/`t.doesNotThrow` documentation (#541)
 - [Deps] update `call-bind`, `is-regex`, `resolve`
 - [Dev Deps] update `eslint`, `aud`
 - [Tests] exclude node v0.6, for now
@yinsang
Copy link

yinsang commented Feb 26, 2021 via email

@cagross
Copy link
Contributor Author

cagross commented Feb 26, 2021

had fixed in the latest version. Sorry

YES, well done 😃 I was just posting here that I remember having a similar issue when I was originally testing that particular case--every test kept passing, even those that should fail. Then I realized my version of tape was 4.14.4. When I updated to v5+, the issue went away.

So you're not the only one it fooled. Actually, maybe I should add a note to the README warning others of that.

@ljharb
Copy link
Collaborator

ljharb commented Feb 26, 2021

I don’t think we need a note in the readme for something that applies to every software project ever written - “check the docs that match the version you’re using”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants