[New] Add --ignore-pattern flag
#587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the --ignore-pattern flag as a shorthand for ignoring test files. The flag may be used together with --ignore; the input will be concatenated in that case. I figured this behavior would make the most sense, since users may want to ignore everything in .gitignore and some other files on top. Fixes tape-testing#586
scottk
approved these changes
Nov 24, 2022
david-gregorian
approved these changes
Nov 24, 2022
ljharb
requested changes
Nov 24, 2022
ljharb
force-pushed
the
ignore-pattern
branch
from
651bb43
to
100f313
Compare
ljharb
changed the title
--ignore-pattern flag
|
I've rebased this, and renamed the flag to All that's missing now is documentation. |
ljharb
force-pushed
the
ignore-pattern
branch
2 times, most recently
from
b3c4940
to
1e1d5fa
Compare
Codecov ReportBase: 96.36% // Head: 96.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 4 4
Lines 632 632
Branches 148 148
=======================================
Hits 609 609
Misses 23 23 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@ljharb cool, thank you 👌 I've added some documentation now, feel free to make any adjustments as needed! |
ljharb
reviewed
Dec 1, 2022
ljharb
force-pushed
the
ignore-pattern
branch
from
0de9ca9
to
8c9fe8e
Compare
ljharb
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the --ignorePattern flag as a shorthand for ignoring test files.
The flag may be used together with --ignore; the input will be concatenated in that case. I figured this behavior would make the most sense, since users may want to ignore everything in .gitignore and some other files on top.
Let me know if this looks good, then I'll also add some documentation :)
Fixes #586