Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev Deps] remove unused intl-fallback-symbol, is-core-module #604

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[Dev Deps] remove unused intl-fallback-symbol, is-core-module #604

merged 1 commit into from
Mar 7, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Mar 7, 2024

is-core-module is nowhere used

ljharb
ljharb approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! these are dev deps, so it's not a big deal, but nice to clean it up.

sadly depcheck doesn't check extensionless files, so it's not a reliable tool in this repo.

Combined with #606.

@ljharb ljharb mentioned this pull request Mar 7, 2024
Merged
@ljharb ljharb changed the title chore: remove is-core-module [Dev Deps] remove unused intl-fallback-symbol, is-core-module Mar 7, 2024
@ljharb ljharb mentioned this pull request Mar 7, 2024
Open
@ljharb ljharb merged commit eafacf6 into tape-testing:master Mar 7, 2024
630 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uzlopak @ljharb