core: inherit diagnostic option in subtests

fixes #984 PR-URL: #985 Credit: @utybo Close: #985 Reviewed-by: @isaacs
tapjs · Jan 19, 2024 · 5e28526 · 5e28526
1 parent eb060c7
commit 5e28526
Show file tree

Hide file tree

Showing 11 changed files with 40 additions and 44 deletions.
diff --git a/src/core/dist/commonjs/test-base.d.ts.map b/src/core/dist/commonjs/test-base.d.ts.map
diff --git a/src/core/dist/commonjs/test-base.js b/src/core/dist/commonjs/test-base.js
diff --git a/src/core/dist/commonjs/test-base.js.map b/src/core/dist/commonjs/test-base.js.map
diff --git a/src/core/dist/esm/test-base.d.ts.map b/src/core/dist/esm/test-base.d.ts.map
diff --git a/src/core/dist/esm/test-base.js b/src/core/dist/esm/test-base.js
diff --git a/src/core/dist/esm/test-base.js.map b/src/core/dist/esm/test-base.js.map
diff --git a/src/core/src/test-base.ts b/src/core/src/test-base.ts
@@ -522,6 +522,7 @@ export class TestBase extends Base<TestBaseEvents> {
       'passes',
       'failTodo',
       'failSkip',
+      'diagnostic',
     ] as const
     for (const k of inheritedFlags) {
       if (

diff --git a/src/core/tap-snapshots/test/test-base.ts.test.cjs b/src/core/tap-snapshots/test/test-base.ts.test.cjs
@@ -51,26 +51,6 @@ TAP version 14
     ok 1 - child # time={TIME}
     
     not ok 2 - cannot create subtest after parent promise resolves
-      ---
-      stack: |
-        Minimal.<anonymous> (test/test-base.ts:1664:13)
-      at:
-        fileName: test/test-base.ts
-        lineNumber: ##
-        columnNumber: ##
-        typeName: Minimal
-        methodName: <anonymous>
-        functionName: Minimal.<anonymous>
-      test: child
-      source: |2
-            if (!subtest) throw new Error('did not get subtest')
-            await p
-            subtest.test('this should not work', async () => {})
-        ------------^
-          })
-          tb.end()
-      ...
-    
     1..2
 not ok 1 - parent # time={TIME}