caching is a terrible idea

tapjs · Dec 17, 2020 · c196db8 · c196db8
1 parent 3745cb2
commit c196db8
Showing 1 changed file with 0 additions and 26 deletions.
diff --git a/lib/mock.js b/lib/mock.js
@@ -1,25 +1,6 @@
 const Module = require('module')
 
-const getKey = (a, b, c) =>
-  `${a}${b}${
-    JSON.stringify(c, (_, val) => typeof val !== 'object' ? String(val) : val)
-  }`
-
 class Mock {
-  static cache () {
-    if (!this._cache)
-      this._cache = new Map()
-    return this._cache
-  }
-
-  static setToCache({ parentFilename, filename, mocks, module }) {
-    this.cache().set(getKey(parentFilename, filename, mocks), module)
-  }
-
-  static getFromCache({ parentFilename, filename, mocks }) {
-    return this.cache().get(getKey(parentFilename, filename, mocks))
-  }
-
   constructor(parentFilename, filename, mocks = {}) {
     this.filename = filename
     this.mocks = new Map()
@@ -37,12 +18,6 @@ class Mock {
 are the same used in ${filename} require calls`)
     }
 
-    const cached = Mock.getFromCache({ parentFilename, filename, mocks })
-    if (cached) {
-      this.module = cached
-      return
-    }
-
     const self = this
     const callerTestRef = Module._cache[parentFilename]
     const filePath = Module._resolveFilename(filename, callerTestRef)
@@ -73,7 +48,6 @@ are the same used in ${filename} require calls`)
 
     this.module = new MockedModule(filePath, callerTestRef)
     this.module.load(filePath)
-    Mock.setToCache({ parentFilename, filename, mocks, module: this.module })
   }
 
   static get(parentFilename, filename, mocks) {