Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tapjs/tapjs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: tap@18.6.1
Choose a base ref
...
head repository: tapjs/tapjs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: tap@18.7.0
Choose a head ref
  • 16 commits
  • 133 files changed
  • 2 contributors

Commits on Dec 9, 2023

  1. use type param for mockImport, mockRequire

    @isaacs
    isaacs committed Dec 9, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    dtolnay David Tolnay
    GPG key ID: F9BA143B95FF6D82
    Verified
    Learn about vigilant mode
    Copy the full SHA
    7b79b31 View commit details

Commits on Jan 18, 2024

  1. tapjs/mock: work around ESM hook deadlock 

    When an ESM hook depends on the main thread to respond, and is
registered prior to another ESM hook being registered, it can deadlock
because the loader freezes the main thread to execute the registration
pseudo-synchronously.

In other words:

- mock loader is registered, now all resolve/load actions will await a
  response from the main thread
- next loader tries to register, using the mock loader (and all previous
  loaders, in fact), *pausing the main thread* to resolve the loader
  module.
- because main thread is paused, @tapjs/mock hook never completes,
  because main thread cannot respond.

The solution here is not really very elegant for solving this problem,
but is a worthwhile optimization in its own right. The client will do
nothing and just fall back to default load/resolve until it gets a
message from the service on the main thread saying that it's been
activated. This message is sent the first time the user calls
`t.mockImport`, since before then there's definitely nothing to mock
anyway.
    @isaacs
    isaacs committed Jan 18, 2024
    Copy the full SHA
    410f1ac View commit details

  2. formatting, and use consistent t.mockImport type hinting

    @isaacs
    isaacs committed Jan 18, 2024
    Copy the full SHA
    eb060c7 View commit details

Commits on Jan 19, 2024

  1. core: inherit diagnostic option in subtests 

    fixes #984

PR-URL: #985
Credit: @utybo
Close: #985
Reviewed-by: @isaacs
    @utybo @isaacs
    utybo authored and isaacs committed Jan 19, 2024
    Copy the full SHA
    5e28526 View commit details

  2. add shell:true to npm spawns for windows benefit 

    Re: #988

Similar to #990, but without adding cross-spawn as a dep.
    @isaacs
    isaacs committed Jan 19, 2024
    Copy the full SHA
    81dd0ad View commit details

  3. ci: test on windows and macos 

    Would've found that build failure issue.
    @isaacs
    isaacs committed Jan 19, 2024
    Copy the full SHA
    4b33e42 View commit details

  4. bootstrap: run nx in --verbose mode

    @isaacs
    isaacs committed Jan 19, 2024
    Copy the full SHA
    51e8a31 View commit details

  5. chore: use --loader in bootstrap 

    The CI was failing for older node versions, because the bootstrap script
was updated to use `--import` instead of `--loader`, which of course is
not going to work for old node versions.

Could have a switch, but since `--loader` still works, may as well just
leave it using the older style, as long as node < 20 is still supported.
    @isaacs
    isaacs committed Jan 19, 2024
    Copy the full SHA
    5063b46 View commit details

  6. remove windows from CI 

    See: nrwl/nx#21246
    @isaacs
    isaacs committed Jan 19, 2024
    Copy the full SHA
    0768324 View commit details

  7. ci: node 20 and 21 only

    @isaacs
    isaacs committed Jan 19, 2024
    Copy the full SHA
    dc8dadd View commit details

Commits on Jan 25, 2024

  1. tcompare: update test to strip out node version specific cruft

    @isaacs
    isaacs committed Jan 25, 2024
    Copy the full SHA
    e906d21 View commit details

  2. always initialize t.context 

    Fix: #994
    @isaacs
    isaacs committed Jan 25, 2024
    Copy the full SHA
    ae2deb7 View commit details

  3. late-bind t.context, so it can be set in before() 

    Fix: #981
    @isaacs
    isaacs committed Jan 25, 2024
    1
    Copy the full SHA
    f105701 View commit details

  4. changelog 18.7

    @isaacs
    isaacs committed Jan 25, 2024
    Copy the full SHA
    2f9abd3 View commit details

  5. remove shell:true from publish script 

    I don't publish from Windows anyway.
    @isaacs
    isaacs committed Jan 25, 2024
    Copy the full SHA
    5bb7ca8 View commit details

  6. update versions 

    @tapjs/worker@1.1.18
@tapjs/typescript@1.4.0
@tapjs/tsx@1.1.19
@tapjs/test@1.4.0
tap@18.7.0
@tapjs/synonyms@1.1.18
@tapjs/stdin@1.1.18
@tapjs/spawn@1.1.18
@tapjs/snapshot@1.2.18
@tapjs/sinon@1.1.18
@tapjs/run@1.5.0
@tapjs/reporter@1.3.16
@tapjs/node-serialize@1.3.0
@tapjs/nock@3.1.18
@tapjs/mock@1.3.0
@tapjs/mocha-globals@1.1.18
@tapjs/intercept@1.2.18
@tapjs/fixture@1.2.18
@tapjs/filter@1.2.18
@tapjs/esbuild-kit@1.1.19
@tapjs/dummy-plugin@1.1.20
@tapjs/create-plugin@1.1.18
@tapjs/core@1.5.0
@tapjs/config@2.4.15
@tapjs/clock@1.1.18
@tapjs/before-each@1.1.18
@tapjs/before@1.1.18
@tapjs/asserts@1.1.18
@tapjs/after-each@1.1.18
@tapjs/after@1.1.18
    @isaacs
    isaacs committed Jan 25, 2024
    Copy the full SHA
    5187113 View commit details
Showing with 1,470 additions and 1,329 deletions.
  1. +7 −4 .github/workflows/ci.yml
  2. +2 −0 .gitignore
  3. +114 −114 package-lock.json
  4. +4 −4 scripts/bootstrap.sh
  5. +1 −1 scripts/default-build.mts
  6. +8 −2 scripts/version.mts
  7. +2 −2 src/after-each/package.json
  8. +2 −2 src/after/package.json
  9. +2 −2 src/asserts/package.json
  10. +3 −1 src/asserts/test/index.ts
  11. +2 −2 src/before-each/package.json
  12. +2 −2 src/before/package.json
  13. +3 −3 src/clock/package.json
  14. +5 −5 src/config/package.json
  15. +47 −52 src/config/test/index.ts
  16. +4 −2 src/config/test/jack.ts
  17. +8 −0 src/core/dist/commonjs/base.d.ts
  18. +1 −1 src/core/dist/commonjs/base.d.ts.map
  19. +7 −9 src/core/dist/commonjs/base.js
  20. +1 −1 src/core/dist/commonjs/base.js.map
  21. +1 −1 src/core/dist/commonjs/test-base.d.ts.map
  22. +1 −1 src/core/dist/commonjs/test-base.js
  23. +1 −1 src/core/dist/commonjs/test-base.js.map
  24. +8 −0 src/core/dist/esm/base.d.ts
  25. +1 −1 src/core/dist/esm/base.d.ts.map
  26. +7 −9 src/core/dist/esm/base.js
  27. +1 −1 src/core/dist/esm/base.js.map
  28. +1 −1 src/core/dist/esm/test-base.d.ts.map
  29. +1 −1 src/core/dist/esm/test-base.js
  30. +1 −1 src/core/dist/esm/test-base.js.map
  31. +2 −2 src/core/package.json
  32. +18 −9 src/core/src/base.ts
  33. +1 −1 src/core/src/test-base.ts
  34. +8 −8 src/core/tap-snapshots/test/base.ts.test.cjs
  35. +0 −20 src/core/tap-snapshots/test/test-base.ts.test.cjs
  36. +4 −2 src/core/test/base.ts
  37. +18 −20 src/core/test/main-script.ts
  38. +3 −3 src/core/test/proc.ts
  39. +37 −2 src/core/test/test-base.ts
  40. +2 −2 src/create-plugin/package.json
  41. +13 −0 src/docs/content/changelog.md
  42. +3 −3 src/dummy-plugin/package.json
  43. +2 −2 src/esbuild-kit/package.json
  44. +3 −3 src/esbuild-kit/test/index.ts
  45. +2 −2 src/filter/package.json
  46. +2 −2 src/fixture/package.json
  47. +3 −3 src/intercept/package.json
  48. +6 −6 src/mocha-globals/package.json
  49. +6 −6 src/mocha-globals/test/index.ts
  50. +1 −0 src/mock/.tshy/commonjs.json
  51. +8 −7 src/mock/README.md
  52. +3 −3 src/mock/package.json
  53. +6 −0 src/mock/src/hooks-url-cjs.cts
  54. +2 −0 src/mock/src/hooks-url.ts
  55. +26 −16 src/mock/src/index.ts
  56. +25 −7 src/mock/src/mock-service-client.ts
  57. +8 −3 src/mock/src/mock-service.ts
  58. +24 −0 src/mock/test/hooks-url.ts
  59. +14 −8 src/mock/test/hooks.ts
  60. +1 −1 src/mock/test/import.ts
  61. +28 −13 src/mock/test/mock-service-client.ts
  62. +4 −4 src/mock/test/mock-service.ts
  63. +3 −3 src/nock/package.json
  64. +2 −2 src/node-serialize/package.json
  65. +8 −10 src/node-serialize/src/serialize.ts
  66. +4 −2 src/node-serialize/test/index.ts
  67. +7 −5 src/node-serialize/test/serialize.ts
  68. +7 −8 src/node-serialize/test/test-message-data.ts
  69. +2 −2 src/node-serialize/test/test-point-message-data.ts
  70. +1 −1 src/node-serialize/test/test-point-results.ts
  71. +3 −3 src/reporter/package.json
  72. +2 −2 src/reporter/tap-snapshots/test/test-results-list.tsx.test.cjs
  73. +18 −18 src/reporter/tap-snapshots/test/test-summary.tsx.test.cjs
  74. +4 −2 src/reporter/test/base.tsx
  75. +4 −2 src/reporter/test/dot.tsx
  76. +8 −9 src/reporter/test/hooks/use-cleanup.ts
  77. +23 −13 src/reporter/test/index.tsx
  78. +4 −2 src/reporter/test/log.tsx
  79. +4 −2 src/reporter/test/min.tsx
  80. +18 −19 src/reporter/test/result-detail-list.tsx
  81. +28 −29 src/reporter/test/result-details.tsx
  82. +24 −25 src/reporter/test/suite-summary.tsx
  83. +4 −2 src/reporter/test/terse.tsx
  84. +20 −21 src/reporter/test/test-results-list.tsx
  85. +16 −17 src/reporter/test/test-summary.tsx
  86. +9 −9 src/run/package.json
  87. +3 −0 src/run/src/npm.ts
  88. +6 −0 src/run/tap-snapshots/test/npm.ts.test.cjs
  89. +11 −7 src/run/test/after.ts
  90. +13 −14 src/run/test/analyze-plugin-arg.ts
  91. +11 −7 src/run/test/before.ts
  92. +24 −34 src/run/test/build.ts
  93. +5 −6 src/run/test/config.ts
  94. +4 −8 src/run/test/debug.ts
  95. +13 −14 src/run/test/execute-test-suite.ts
  96. +75 −81 src/run/test/get-install-set.ts
  97. +15 −16 src/run/test/handle-reporter.ts
  98. +6 −8 src/run/test/list.ts
  99. +14 −14 src/run/test/main-config.ts
  100. +16 −20 src/run/test/npm.ts
  101. +18 −20 src/run/test/output-dir.ts
  102. +65 −68 src/run/test/output-file.ts
  103. +61 −35 src/run/test/plugin.ts
  104. +11 −7 src/run/test/repl.ts
  105. +5 −6 src/run/test/repl/file-completer.ts
  106. +31 −36 src/run/test/repl/index.ts
  107. +5 −6 src/run/test/repl/watch.ts
  108. +4 −2 src/run/test/replay.ts
  109. +45 −30 src/run/test/report.ts
  110. +4 −2 src/run/test/run.ts
  111. +21 −21 src/run/test/save-list.ts
  112. +91 −97 src/run/test/select-version.ts
  113. +12 −16 src/run/test/test-argv.ts
  114. +14 −16 src/run/test/test-is-serial.ts
  115. +11 −12 src/run/test/version.ts
  116. +3 −3 src/sinon/package.json
  117. +2 −2 src/snapshot/package.json
  118. +4 −2 src/snapshot/test/clean-cwd.ts
  119. +2 −2 src/spawn/package.json
  120. +10 −11 src/stack/test/call-site-like.ts
  121. +2 −2 src/stdin/package.json
  122. +3 −3 src/synonyms/package.json
  123. +19 −19 src/tap/package.json
  124. +2 −46 src/tcompare/tap-snapshots/test/format.tsx.test.cjs
  125. +2 −0 src/tcompare/test/format.tsx
  126. +17 −17 src/test/package.json
  127. +13 −1 src/test/scripts/build.mts
  128. +2 −2 src/tsx/package.json
  129. +3 −3 src/tsx/test/index.ts
  130. +2 −2 src/typescript/package.json
  131. +2 −1 src/typescript/src/index.ts
  132. +12 −16 src/typescript/test/index.ts
  133. +2 −2 src/worker/package.json
11 changes: 7 additions & 4 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -10,12 +10,15 @@ on:

jobs:
test:
runs-on: ${{ matrix.os }}

strategy:
matrix:
node-version: [16.x, 18.x, 20.7.x]
os: [ubuntu-latest]
node-version: [20.x, 21.x]
os: [ubuntu-latest, macos-latest]

runs-on: ${{ matrix.os }}
defaults:
run:
shell: bash

steps:
- uses: actions/checkout@v3
2 changes: 2 additions & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/node_modules
/.tsimp
/src/*/.tsimp
/docs
/src/*/.tshy-build-tmp
/src/*/node_modules
Loading