Buffered tests #309
Merged
Buffered tests #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
buffered-tests
branch
5 times, most recently
from
38712d5
to
f00523d
Compare
This requires an update to the parser, which also allows removing a lot of dead code.
isaacs
force-pushed
the
buffered-tests
branch
from
d4cacf0
to
d7de351
Compare
2 similar comments
This also updates to make buffered child bailouts less clunky
Juggling the alphabet is too hard as the number of tests and cases increases. Passing two booleans to a function feels like it should probably be an options object, but whatever. We can cross that bridge later. Also, this allows running a single case in an ad-hoc manner which is a bit more convenient in development.
Simulates cases where the 'TAP_etc' environs aren't handled in any sort of way in the child process test. Particularly, the output for bail-on-failure and buffered parent when the non-buffered non-bail-on-fail child has a failure midstream, is not very ideal. Printing the extra data is debatably valuable, but the fact that it lists the test name as the bailout reason rather than the original failure is very unfortunate. Ideally, it'd be treated just like when a non-child-process test bails out.
2 similar comments
1 similar comment
Also, move the code around a little bit so that it'll be more straightforward to have yaml diagnostics ahead of buffered child test output once that's supported by the parser.
Otherwise it's pretty crowded and noisy. However, to prevent double-spacing, also change some of the logic around how and when subtest asserts get spaced (always putting a space after a child test point).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a wip for #305. Do not land yet.
}and then bail out at top level, like with streaming subtests)1..0) asTODO, maybe?{until the next thing at that indentation level, so that the bailout happens at the error, not before the actual error is printed.