Exit with the yaml parse error on bad rc files #614
Conversation
|
NB: a missing rcfile is still fine, which does mean you could do |
bin/run.js
Outdated
| @@ -827,3 +829,10 @@ try { | |||
| throw er | |||
| } | |||
| } | |||
|
|
|||
| try { | |||
| process.on('unhandledRejection', onError) | |||
There was a problem hiding this comment.
This is new, should process.off be added after the call to jack?
Otherwise this looks fine and I've verified it acts as I expect when .taprc is invalid.
There was a problem hiding this comment.
Turns out that removing the handler right after teh call to jack removes it before it can be relevant, because async function.
Updated branch with another approach that seems to work.
There was a problem hiding this comment.
Retested with the updated branch, still resolves the issue for me.
isaacs
force-pushed
the
throw-on-bad-yaml-rcfile
branch
from
8d2dc99
to
e09d227
Compare
Fix #613