Remove unused variables / add linting #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
commented
May 3, 2021
| @@ -692,6 +691,7 @@ Much more documentation available at: https://www.node-tap.org/ | |||
| appended to the filenames.`, | |||
| }), | |||
|
|
|||
| /* eslint-disable-next-line */ | |||
There was a problem hiding this comment.
I'm not sure what to do here. There's a lot of code in here and it's hard to see it all. So I just disable the warning. However, if it is accurate, then I think this key will take precedence over the first definition.
There was a problem hiding this comment.
To be clear: this comment directive is disabling a "duplicate key" warning.
|
ping: @isaacs @coreyfarrell |
PR-URL: tapjs#748 Credit: @jsumners Close: tapjs#748 Reviewed-by: @isaacs EDIT(@isaacs): move lint to postsnap, and do --fix by default. We always have to run snapshots before pushing a new version, and expect to get code changes as a result. This is much more convenient than having tests just not run becuase of some scaffolding or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my last few PRs I have noticed that there are many unused variables across the code. This can lead to issues as we saw in #745. This PR adds eslint to catch these sorts of errors. The eslint configuration is based on the standard "eslint:recommended" rule set. I have disabled:
no-prototype-builtinsno-emptyno-regex-spacesno-useless-escapeI have disabled these so that this PR has minimal impact on the code. I recommend someone who knows both the code and the regular expressions to re-enable the
no-regex-spacesandno-useless-escaperules and fixing the code accordingly.