Isaacs/node 20 loaders #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If plugins export an `importLoader`, and Module.register exists, then
use that instead of their `loader` export.
process.exitCode became {configurable:false} in
nodejs/node#44711
Can bring back exitCode interception when/if it becomes configurable
again, re nodejs/node#49579
For now, just set it, and then verify it's the expected value, and put
it back to 0 if so.
Some error stack frames string values changed subtly. Test some things in both CJS and MJS flavors, because this module is loaded as part of the load process, and then is already cached when coverage is applied, so we need to run the tests against both to get full coverage to register.
Might make this the default.
20.6.0 had a bug that broke module loading order of CJS in some cases
isaacs
force-pushed
the
isaacs/node-20-loaders
branch
2 times, most recently
from
2b0fb16
to
4b23ce8
Compare
v12 hasn't been supported for a long time, and this check is a false-positive on node v20
isaacs
force-pushed
the
isaacs/node-20-loaders
branch
2 times, most recently
from
a0ba25f
to
fd9908e
Compare
They have the code in the stack string in a weird way This also normalizes the \n ending for all stack strings, and fixes an issue where thrown Error stacks were being re-parsed incorrectly instead of respecting the stack that was already parsed in a previous step.
isaacs
force-pushed
the
isaacs/node-20-loaders
branch
from
fd9908e
to
c5972e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.