Isaacs/node test interop #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The `--before` should not trigger a double-register and pipe to standard output. Defend against that better. 2. The `--after` should hold the process open unil the after process closes. Fix: #909
|
CI is actually passing, I just canceled the |
resolve() and relative() can throw in some cases
The TestPoint class should really be *strictly* a string generator, having pass/fail change in that function muddies the waters. Part of TestBase's (admittedly, overly large) job is to determine whether a test point should be a pass or a failure, so that it can decide whether to show diagnostics, capture a stack trace, and so on.
isaacs
force-pushed
the
isaacs/node-test-interop
branch
from
45db207
to
81044bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #888