Move rocks building in build phase #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or we can use multistage builds testcontainers/testcontainers-java#4810 |
ArtDu
force-pushed
the
rocks_in_image
branch
2 times, most recently
from
2f779f2
to
aaf1cb5
Compare
akudiyar
suggested changes
May 29, 2023
| @@ -21,8 +21,7 @@ public class TarantoolCartridgeBootstrapFromLuaWithFixedPortsTest { | |||
| "Dockerfile", | |||
| "cartridge/instances_fixedport.yml", | |||
| "cartridge/topology_fixedport.lua") | |||
| .withCopyFileToContainer(MountableFile.forClasspathResource("cartridge"), "/app") | |||
There was a problem hiding this comment.
Let's leave this since on Windows mapping folders may not work. These lines were added for a purpose. We need to check that the new code will work on all platforms
There was a problem hiding this comment.
Probably we need to use copy on Windows platform in the container code too, and then remove it here
There was a problem hiding this comment.
Another option is to make copy optional, and pass a corresponding flag to the container setup. That looks like the most universal solution.
There was a problem hiding this comment.
We've already tested it here #70 (comment) . But I removed binding here at all
ArtDu
force-pushed
the
rocks_in_image
branch
2 times, most recently
from
492559a
to
b9dcdbe
Compare
iDneprov
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't forgotten about:
Related issues: