Skip to content

Commit

Permalink
deps: V8: forward declaration of Rtl*FunctionTable
Browse files Browse the repository at this point in the history
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
refack authored and targos committed Sep 17, 2021
1 parent dab42b4 commit 68fa4cb
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.2',
'v8_embedder_string': '-node.3',

##### V8 defaults for Node.js #####

Expand Down
30 changes: 30 additions & 0 deletions deps/v8/src/diagnostics/unwinding-info-win64.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,36 @@
// This has to come after windows.h.
#include <versionhelpers.h> // For IsWindows8OrGreater().

// Forward declaration to keep this independent of Win8
NTSYSAPI
DWORD
NTAPI
RtlAddGrowableFunctionTable(
_Out_ PVOID* DynamicTable,
_In_reads_(MaximumEntryCount) PRUNTIME_FUNCTION FunctionTable,
_In_ DWORD EntryCount,
_In_ DWORD MaximumEntryCount,
_In_ ULONG_PTR RangeBase,
_In_ ULONG_PTR RangeEnd
);


NTSYSAPI
void
NTAPI
RtlGrowFunctionTable(
_Inout_ PVOID DynamicTable,
_In_ DWORD NewEntryCount
);


NTSYSAPI
void
NTAPI
RtlDeleteGrowableFunctionTable(
_In_ PVOID DynamicTable
);

namespace v8 {
namespace internal {
namespace win64_unwindinfo {
Expand Down

0 comments on commit 68fa4cb

Please sign in to comment.