Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-rodio-to-0.13: Update the "rodio" dependency to version 0.13 and bump crate version #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marin-m
Copy link

@marin-m marin-m commented Nov 8, 2020

Hello,

This pull request updates the rodio dependency, updates the corresponding code in the sample CLI and also bumps the crate version, because:

  • rodio APIs have changed and developers may want to integrate it in more recent code
  • Recent rodio version also have fixed critical bugs with MP3 decoding
  • Once merged, more potential code will be able to be compatible with your library

Also, thanks for your nice crate!

@marin-m
Copy link
Author

marin-m commented Nov 25, 2020

Hello,

Is it acceptable that I create a fork of this create with an updated dependency specification, so that I can integrate it in my project?

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant