This repository has been archived by the owner on Jan 18, 2019. It is now read-only.
Upgrade neutrino packages #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upgrading to latest neutrino throws errors. Running ➜ taskcluster-web-server git:(lint) ✗ yarn lint
yarn run v1.12.3
warning ../package.json: No license field
$ eslint --cache --format codeframe --ext mjs,js src test
An error occurred when loading the Neutrino configuration.
{ Error: Cannot find module 'babel-plugin-eslint-plugin-prettier' from '/Users/haali/Documents/Mozilla/projects/taskcluster-web-server'
- If you want to resolve "eslint-plugin-prettier", use "module:eslint-plugin-prettier"
at Function.module.exports [as sync] (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/resolve/lib/sync.js:43:15)
at resolveStandardizedName (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@babel/core/lib/config/files/plugins.js:101:31)
at resolvePlugin (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@babel/core/lib/config/files/plugins.js:54:10)
at reduce (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/babel-merge/dist/index.js:21:26)
at Array.reduce (<anonymous>)
at mergeArray (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/babel-merge/dist/index.js:20:36)
at babelMerge (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/babel-merge/dist/index.js:40:19)
at lintRule.use.tap.lintOptions (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@neutrinojs/mocha/src/index.js:11:11)
at Object.tap (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/webpack-chain/src/Use.js:14:20)
at module.exports.neutrino (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@neutrinojs/mocha/src/index.js:7:28) code: 'MODULE_NOT_FOUND' }
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.Running ➜ taskcluster-web-server git:(lint) yarn start
yarn run v1.12.3
warning ../package.json: No license field
$ webpack --watch --mode development
An error occurred when loading the Neutrino configuration.
{ Error: Cannot find module 'babel-plugin-eslint-plugin-prettier' from '/Users/haali/Documents/Mozilla/projects/taskcluster-web-server'
- If you want to resolve "eslint-plugin-prettier", use "module:eslint-plugin-prettier"
at Function.module.exports [as sync] (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/resolve/lib/sync.js:43:15)
at resolveStandardizedName (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@babel/core/lib/config/files/plugins.js:101:31)
at resolvePlugin (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@babel/core/lib/config/files/plugins.js:54:10)
at reduce (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/babel-merge/dist/index.js:21:26)
at Array.reduce (<anonymous>)
at mergeArray (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/babel-merge/dist/index.js:20:36)
at babelMerge (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/babel-merge/dist/index.js:40:19)
at lintRule.use.tap.lintOptions (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@neutrinojs/mocha/src/index.js:11:11)
at Object.tap (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/webpack-chain/src/Use.js:14:20)
at module.exports.neutrino (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@neutrinojs/mocha/src/index.js:7:28)
at Neutrino.use (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/neutrino/Neutrino.js:211:7)
at Neutrino.use (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/neutrino/Neutrino.js:216:12)
at middleware.use.map.usage (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/neutrino/Neutrino.js:236:44)
at Array.map (<anonymous>)
at Neutrino.use (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/neutrino/Neutrino.js:236:26)
at Neutrino.use (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/neutrino/Neutrino.js:216:12)
at middleware.use.map.usage (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/neutrino/Neutrino.js:236:44)
at Array.map (<anonymous>)
at Neutrino.use (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/neutrino/Neutrino.js:236:26)
at module.exports (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/neutrino/index.js:36:16)
at Object.<anonymous> (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/webpack.config.js:3:18)
at Module._compile (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/v8-compile-cache/v8-compile-cache.js:178:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)
at Module.load (internal/modules/cjs/loader.js:589:32)
at tryModuleLoad (internal/modules/cjs/loader.js:528:12)
at Function.Module._load (internal/modules/cjs/loader.js:520:3)
at Module.require (internal/modules/cjs/loader.js:626:17)
at require (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
at WEBPACK_OPTIONS (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/webpack-cli/bin/convert-argv.js:133:13)
at requireConfig (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/webpack-cli/bin/convert-argv.js:135:6) code: 'MODULE_NOT_FOUND' }
error Command failed with exit code 1. |
|
@edmorley Any idea why this is happening? Regenerating |
|
I believe this is because as of neutrinojs/neutrino#1182 taskcluster-web-server/.neutrinorc.js Lines 5 to 8 in be555aa The plugin needs to be referred to as |
|
@edmorley I switched to using ➜ taskcluster-web-server git:(lint) yarn lint
yarn run v1.12.3
warning ../package.json: No license field
$ eslint --cache --format codeframe --ext mjs,js src test
An error occurred when loading the Neutrino configuration.
{ Error: Cannot find module 'babel-plugin-prettier' from '/Users/haali/Documents/Mozilla/projects/taskcluster-web-server'
- If you want to resolve "prettier", use "module:prettier"
at Function.module.exports [as sync] (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/resolve/lib/sync.js:43:15)
at resolveStandardizedName (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@babel/core/lib/config/files/plugins.js:101:31)
at resolvePlugin (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@babel/core/lib/config/files/plugins.js:54:10)
at reduce (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/babel-merge/dist/index.js:21:26)
at Array.reduce (<anonymous>)
at mergeArray (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/babel-merge/dist/index.js:20:36)
at babelMerge (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/babel-merge/dist/index.js:40:19)
at lintRule.use.tap.lintOptions (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@neutrinojs/mocha/src/index.js:11:11)
at Object.tap (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/webpack-chain/src/Use.js:14:20)
at module.exports.neutrino (/Users/haali/Documents/Mozilla/projects/taskcluster-web-server/node_modules/@neutrinojs/mocha/src/index.js:7:28) code: 'MODULE_NOT_FOUND' }
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. |
|
If I remove I'll open a Neutrino PR. (Guess just shows how few people use the Mocha preset that no one has hit it so far!) |
edmorley
added a commit
to neutrinojs/neutrino
that referenced
this pull request
Nov 23, 2018
The refactor in #1182 inadvertently used babel-merge's `merge()` to merge ESLint configuration in this preset rather than deepmerge, since the existing `merge` import was not the same as in other presets from which the lint rule merging block was copied. In a later PR I think we should stop exporting a merge function from `@neutrinojs/compile-loader` named `merge`, to avoid the reduce the chance of this kind of naming conflict. Fixes: taskcluster/taskcluster-web-server#59 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.