Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added NixOS prerequisites #1801

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

JanotLeLapin
Copy link

I added a minimal flake.nix sample that provides a dev shell with all required packages. This might be a lot when compared to other distributions prerequisites, but I figured I'd contribute anyways since I'm running NixOS right now and I can cargo tauri dev and cargo tauri build using this flake.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1702df0
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65a03d72ede1660008b4244d
😎 Deploy Preview https://deploy-preview-1801--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@FabianLars
Copy link
Member

Hi, thanks for contributing! Merging this may take a while because we are a bit unsure about nix and nixos right now, see tauri-apps/tauri#8588 (comment).

Also, this looks quite different to the 2 templates other people contributed to the stable docs: tauri-apps/tauri#8588 (comment) and to what i've seen in tauri's github issues. I'm not saying yours is wrong, but since i don't use nix/nixos myself i'd like to hear more nix users chime in :)

Lastly, is it possible to use stable rust? I'd really rather not recommend nightly in our docs.

@simonhyll simonhyll added this to the Version 2.0 milestone Feb 26, 2024
@simonhyll simonhyll requested a review from a team February 29, 2024 00:59
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't mind me, just blocking the merge (see above)

@simonhyll simonhyll added the enhancement Does it add or improve content? label May 21, 2024
nativeBuildInputs = [ pkgs.pkg-config ];
buildInputs = [
(pkgs.rust-bin.fromRustupToolchain {
channel = "nightly-2023-12-19"; # feel free to change the channel

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable channel as requested

Suggested change
channel = "nightly-2023-12-19"; # feel free to change the channel
channel = "stable";

pkgs.webkitgtk_4_1
pkgs.openssl
pkgs.cargo-tauri
pkgs.trunk
Copy link

@ninelore ninelore Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently build fails because of missing libudev.pc, which is included in systemd

Suggested change
pkgs.trunk
pkgs.trunk
pkgs.systemdLibs

Copy link

@ninelore ninelore Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one might actually be unrelated to Tauri itself but the project I've tested it with.
Need to confirm later

@ninelore
Copy link

Aside from these issues LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content?
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants