Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a splashscreen lab #2106

Merged
merged 10 commits into from
Jun 6, 2024
Merged

Conversation

simonhyll
Copy link
Sponsor Contributor

@simonhyll simonhyll commented May 1, 2024

What kind of changes does this PR include?

  • New or updated content

Description

Adds a new splashscreen lab.

Copy link

netlify bot commented May 1, 2024

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a642db2
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/66620f943ab1fe0007005e25
😎 Deploy Preview https://deploy-preview-2106--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@simonhyll simonhyll marked this pull request as ready for review May 21, 2024 16:30
@simonhyll simonhyll requested a review from a team as a code owner May 21, 2024 16:30
@simonhyll
Copy link
Sponsor Contributor Author

It's not perfect yet but it's close enough now where I'd like some input on it. 😄

@simonhyll simonhyll added this to the Version 2.0 milestone May 21, 2024
@simonhyll simonhyll added enhancement Does it add or improve content? tauri 2.0 docs and removed tauri 2.0 docs labels May 21, 2024
@simonhyll simonhyll requested a review from vasfvitor May 23, 2024 17:44
@vasfvitor
Copy link
Contributor

I'm just looking at it right now lol, good timing

@vasfvitor
Copy link
Contributor

what do you think of adding the full CLI as a way to quick start?
I guess it should be

pnpm create tauri-app --beta --template vanilla --manager pnpm --mobile yes splashscreen-lab

@vasfvitor
Copy link
Contributor

I'm gonna follow the lab and give my feedback based on it

@simonhyll simonhyll self-assigned this May 23, 2024
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, even after the requested changed it doesn't work. Tried to fix it, broke even more. I could give another shot, or do you want to do it yourself?

Is the goal to teach about state? Because if not, I think, if possible, it should be done without it. Or else, add a requirement lab that teaches about managing state. Speaking of which, I've read many times your webpage about state and it helped me A LOT when I needed it , really!

src/content/docs/learn/splashscreen.mdx Show resolved Hide resolved
src/content/docs/learn/splashscreen.mdx Outdated Show resolved Hide resolved
src/content/docs/learn/splashscreen.mdx Outdated Show resolved Hide resolved
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @simonhyll, I left just a tiny suggestion 🫡

src/content/docs/learn/splashscreen.mdx Outdated Show resolved Hide resolved
@simonhyll
Copy link
Sponsor Contributor Author

what do you think of adding the full CLI as a way to quick start? I guess it should be

pnpm create tauri-app --beta --template vanilla --manager pnpm --mobile yes splashscreen-lab

@vasfvitor The main reason I didn't do that was because it's very convenient to just add the CTA fragment we have to things and keep that as the main for everyone. Giving the full command feels less real-world adapted, the lab aims to provide some practical experience after all, might as well make people use the method they'd use the most in the future right? And if we do a full command we'd need to provide it for all package managers.

@simonhyll
Copy link
Sponsor Contributor Author

well, even after the requested changed it doesn't work. Tried to fix it, broke even more. I could give another shot, or do you want to do it yourself?

Is the goal to teach about state? Because if not, I think, if possible, it should be done without it. Or else, add a requirement lab that teaches about managing state. Speaking of which, I've read many times your webpage about state and it helped me A LOT when I needed it , really!

Glad to head the article is of use to people ❤️

It's not explicitly the intent to teach about states but I also have a hard time seeing how to tackle this without states, or rather I have a hard time seeing a more appropriate solution to this specific use-case. We can definitely add a reference link to where people can read up more on states, not sure I'd say it's a prerequisite necessarily, I think I can include a very short text on what states are in the lab and it'll be good enough for the sort of copy-paste nature of labs

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😁

Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest adding "decorations": false to make it feel more splashyscreeney, but it just looks bad with square edges, I'm not sure it's possible to round it

@simonhyll
Copy link
Sponsor Contributor Author

@vasfvitor Yea it can be improved upon, especially considering right now I haven't touched upon how to do the splashscreen for mobile devices, but it's a start 🙂 We'll merge it and then get followup PR's for improving it

@simonhyll simonhyll merged commit 143859a into tauri-apps:v2 Jun 6, 2024
8 checks passed
@simonhyll simonhyll deleted the learn/splashscreen branch June 6, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content?
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants