Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily pin clap version #3051

Closed
wants to merge 1 commit into from
Closed

temporarily pin clap version #3051

wants to merge 1 commit into from

Conversation

FabianLars
Copy link
Member

@FabianLars FabianLars commented Dec 9, 2021

For whatever reason, cargo resolves beta.5 to rc.0 (it didn't do that between beta releases). This breaks both the released cli and the next version mainly because they completely removed the yaml api.
So if we rewrite the cli to use the builder or derive api soon enough, then i don't expect this to be merged, but at least i can tell users with this problem to install the cli from this branch instead.

Edit: Nevermind they only deprecated the yaml feature for now. I'll take a look on what they changed that breaks our cli.

Edit2 (from discord): "tbf the fixes are pretty easy (another feature flag for macros, App::from -> App::from_yaml, arg.hidden -> arg.hide), but i don't know if it's worth it if the yaml api is supposedly so bad (clap-rs/clap#3087)"

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@FabianLars FabianLars requested a review from a team December 9, 2021 09:52
@epage
Copy link

epage commented Dec 9, 2021

For whatever reason, cargo resolves beta.5 to rc.0 (it didn't do that between beta releases).

Yes, this is a bit annoying that preleases are considered semver compatible with each other. See https://internals.rust-lang.org/t/changing-cargo-semver-compatibility-for-pre-releases/14820/2

@lucasfernog
Copy link
Member

We've updated clap to 3.0.0-rc.0 instead: #2928

@lucasfernog lucasfernog closed this Dec 9, 2021
@lucasfernog lucasfernog deleted the tmp/pin-clap branch December 9, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants