Skip to content

feat(api): Add exists function to the fs module. #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 15, 2022
Merged

Conversation

FabianLars
Copy link
Member

Really just putting it up here so we don't forget it lol

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary - It's basically our most requested api.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
FabianLars Fabian-Lars

Verified

This commit was signed with the committer’s verified signature.
FabianLars Fabian-Lars
@FabianLars FabianLars requested a review from a team as a code owner August 26, 2022 22:47
@FabianLars FabianLars mentioned this pull request Sep 7, 2022
lucasfernog and others added 3 commits September 15, 2022 08:24

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lucasfernog Lucas Fernandes Nogueira

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lucasfernog Lucas Fernandes Nogueira

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lucasfernog lucasfernog merged commit 3c62dbc into dev Sep 15, 2022
@lucasfernog lucasfernog deleted the feat/exists-api branch September 15, 2022 14:28
lucasfernog pushed a commit that referenced this pull request Nov 8, 2022

Partially verified

This commit is signed with the committer’s verified signature. The key has expired.
lucasfernog’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
This reverts commit 3c62dbc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants