Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): escape glob characters in drop/dialogs , closes #5234 #5237

Merged
merged 5 commits into from
Oct 4, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 19, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
amrbashir Amr Bashir
@amrbashir amrbashir requested a review from a team as a code owner September 19, 2022 14:20
lucasfernog
lucasfernog previously approved these changes Sep 19, 2022

Verified

This commit was signed with the committer’s verified signature.
amrbashir Amr Bashir
amrbashir and others added 3 commits September 19, 2022 16:56

Verified

This commit was signed with the committer’s verified signature.
amrbashir Amr Bashir

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lucasfernog Lucas Fernandes Nogueira

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lucasfernog Lucas Fernandes Nogueira
@lucasfernog lucasfernog merged commit 4cbdf0f into dev Oct 4, 2022
@lucasfernog lucasfernog deleted the escape-glob branch October 4, 2022 22:50
lucasfernog added a commit that referenced this pull request Nov 8, 2022

Verified

This commit was signed with the committer’s verified signature. The key has expired.
lucasfernog Lucas Fernandes Nogueira
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
lucasfernog added a commit that referenced this pull request Nov 8, 2022

Partially verified

This commit is signed with the committer’s verified signature. The key has expired.
lucasfernog’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
lucasfernog added a commit that referenced this pull request Nov 8, 2022

Partially verified

This commit is signed with the committer’s verified signature. The key has expired.
lucasfernog’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants