Prevent interaction start if control clicking #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taye
reviewed
Apr 7, 2022
There was a problem hiding this comment.
Thanks for the PR.
I don't think Interaction.ts is the right place to check for this. It would be more appropriate to do this in the auto-start plugin, but with some configuration options. I imagine there are many use cases where ctrl+drag is wanted and the context menu is then prevented from opening.
Ideally we could preserve the current behaviour by default (even with the context menu issue, to avoid a breaking change 😕) and add options to prevent start when certain modifier keys are pressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to prevent objects sticking to cursor in issue #954. Causes any interaction started with the ctrlKey to be stopped.