Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing .prototype property entries for DisposableStack/AsyncDisposableStack #167

Merged
merged 1 commit into from Jul 13, 2023

Conversation

rbuckton
Copy link
Collaborator

This adds entries that were missing that are necessary to describe the behavior of the .prototype property on the DisposableStack and AsyncDisposableStack constructors.

cc: @tc39/ecma262-editors

@github-actions
Copy link

A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/167.

@rbuckton
Copy link
Collaborator Author

Quick clarification: Would this be considered an editorial change since there was no obvious intention to explicitly exclude prototype here, or a needs consensus PR? Im happy to hold off on merging if this needs consensus, even if only perfunctorily.

@ljharb
Copy link
Member

ljharb commented Jun 23, 2023

Seems like it's normative, but an obvious oversight - so i'd say you can either wait til plenary, or, just merge it and simply notify plenary (obv with the ability to revert it if there were pushback)

@rbuckton rbuckton added the needs-consensus A pull request that needs consensus at TC39 plenary label Jun 27, 2023
@rbuckton
Copy link
Collaborator Author

This was approved by consensus at the July, 2023 TC39 Plenary, but still needs reviews from the editors and reviewers before I can merge.

@waldemarhorwat, @syg, @michaelficarra, @bakkot: can you please review?

@rbuckton rbuckton added the has-consensus Indicates a pull request reached consensus at TC39 plenary. label Jul 13, 2023
@rbuckton rbuckton merged commit a3edfa6 into main Jul 13, 2023
1 check passed
@rbuckton rbuckton deleted the add-missing-prototype-entries branch July 13, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-consensus Indicates a pull request reached consensus at TC39 plenary. needs-consensus A pull request that needs consensus at TC39 plenary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants